Skip to content

update CI jobs#101

Merged
aplavin merged 8 commits into
masterfrom
ci-versions
Mar 15, 2025
Merged

update CI jobs#101
aplavin merged 8 commits into
masterfrom
ci-versions

Conversation

@aplavin

@aplavin aplavin commented Mar 15, 2025

Copy link
Copy Markdown
Member

The goal is to make all CI tests pass, so that logs from other PRs can be assessed more easily (specifically #99 and #100).

@aplavin

aplavin commented Mar 15, 2025

Copy link
Copy Markdown
Member Author

Setfield tests seem to be failing on 1.10 and 1.11. I guess it's just a matter of too aggressive timing comparison... Is it ok to remove Setfield on 1.10+ from integration tests for now, @jw3126?

Flatten appears to be genuinely broken on 1.11. Is it ok to remove Flatten on 1.11+ from integration tests for now, @rafaqz?

@rafaqz

rafaqz commented Mar 15, 2025

Copy link
Copy Markdown
Member

Yeah noticed these, a lot of changes in Base

Flatten.jl is still apparently working in practice where it's used, so may also be some tests like thosr in Setfield. It just hasn't had any new PRs on 1.11.

I'll try to look at it this week it's good to have tested here

@aplavin

aplavin commented Mar 15, 2025

Copy link
Copy Markdown
Member Author

I guess I'll merge as-is, we'll just keep in mind these three failures for now. It is definitely an improvement already.

@aplavin aplavin merged commit b987640 into master Mar 15, 2025
@aplavin aplavin deleted the ci-versions branch March 15, 2025 14:49
@rafaqz

rafaqz commented Mar 15, 2025

Copy link
Copy Markdown
Member

Thanks

@jw3126

jw3126 commented Mar 15, 2025

Copy link
Copy Markdown
Member

Thanks. Setfield.jl can be removed in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants